Leverage Docker Layer System (#1191)

Dockerfile best practices recommend to move the installation of external dependencies before specific code.
This will improve local development experience by improving Docker cache management
and it will improve final Docker images compaction by sharing the first layers.

diff --git a/Dockerfile b/Dockerfile
index 649bc327c21dc3c81877cd0d8c252d0e5d97cea2..d312df15083197e0f2af3f9af380c7c52406b4f7 100644 (file)
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,9 +1,13 @@
 FROM ubuntu:20.04
 
 ARG TARGETARCH
-COPY ./dist/${TARGETARCH}/ttyd /usr/bin/ttyd
+
+# Dependencies
 RUN apt-get update && apt-get install -y --no-install-recommends tini && rm -rf /var/lib/apt/lists/*
 
+# Application
+COPY ./dist/${TARGETARCH}/ttyd /usr/bin/ttyd
+
 EXPOSE 7681
 WORKDIR /root
 

diff --git a/Dockerfile.alpine b/Dockerfile.alpine
index 41378a1dcab2c1b49469d92d6c6a8b08a83c9965..141d56fe4a151284b74cb1329cf98d6167d39495 100644 (file)
--- a/Dockerfile.alpine
+++ b/Dockerfile.alpine
@@ -1,9 +1,13 @@
 FROM alpine
 
 ARG TARGETARCH
-COPY ./dist/${TARGETARCH}/ttyd /usr/bin/ttyd
+
+# Dependencies
 RUN apk add --no-cache bash tini
 
+# Application
+COPY ./dist/${TARGETARCH}/ttyd /usr/bin/ttyd
+
 EXPOSE 7681
 WORKDIR /root