From: Shuanglei Tao <tsl0922@gmail.com>
Date: Sun, 8 Aug 2021 13:17:36 +0000 (+0800)
Subject: http: polish basic auth code
X-Git-Url: http://git.prime8.dev/?a=commitdiff_plain;h=8a75364a76910dd627bb40df8206bc4190743701;p=ttyd.git

http: polish basic auth code
---

diff --git a/src/http.c b/src/http.c
index b6e8ca8..e537863 100644
--- a/src/http.c
+++ b/src/http.c
@@ -20,19 +20,8 @@ static int check_auth(struct lws *wsi, struct pss_http *pss) {
 
   char buf[256];
   int len = lws_hdr_copy(wsi, buf, sizeof(buf), WSI_TOKEN_HTTP_AUTHORIZATION);
-  if (len > 0) {
-    // extract base64 text from authorization header
-    char *ptr = &buf[0];
-    char *token, *b64_text = NULL;
-    int i = 1;
-    while ((token = strsep(&ptr, " ")) != NULL) {
-      if (strlen(token) == 0) continue;
-      if (i++ == 2) {
-        b64_text = token;
-        break;
-      }
-    }
-    if (b64_text != NULL && !strcmp(b64_text, server->credential)) return AUTH_OK;
+  if (len >= 7 && strstr(buf, "Basic ")) {
+    if (!strcmp(buf +6, server->credential)) return AUTH_OK;
   }
 
   unsigned char buffer[1024 + LWS_PRE], *p, *end;