From 21b9aefbe3fa03aadb72499f56f8b3ef89a53141 Mon Sep 17 00:00:00 2001 From: Shuanglei Tao Date: Thu, 11 Mar 2021 22:56:07 +0800 Subject: [PATCH] protocol: cleanup unused code --- src/protocol.c | 9 +-------- src/pty.c | 5 ++++- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/protocol.c b/src/protocol.c index 8523b72..e689acf 100644 --- a/src/protocol.c +++ b/src/protocol.c @@ -258,14 +258,7 @@ int callback_tty(struct lws *wsi, enum lws_callback_reasons reason, void *user, switch (command) { case INPUT: if (server->readonly) break; - - char *data = xmalloc(pss->len - 1); - memcpy(data, pss->buffer + 1, pss->len - 1); - - uv_write_t *req = xmalloc(sizeof(uv_write_t)); - req->data = data; - - int err = pty_write(pss->process, pty_buf_init(data, pss->len - 1)); + int err = pty_write(pss->process, pty_buf_init(pss->buffer + 1, pss->len - 1)); if (err) { lwsl_err("uv_write: %s (%s)\n", uv_err_name(err), uv_strerror(err)); return -1; diff --git a/src/pty.c b/src/pty.c index 1db5baa..03f6557 100644 --- a/src/pty.c +++ b/src/pty.c @@ -136,7 +136,10 @@ void pty_resume(pty_process *process) { } int pty_write(pty_process *process, pty_buf_t *buf) { - if (process == NULL) return UV_ESRCH; + if (process == NULL) { + pty_buf_free(buf); + return UV_ESRCH; + } pty_io_t *io = process->io; uv_buf_t b = uv_buf_init(buf->base, buf->len); uv_write_t *req = xmalloc(sizeof(uv_write_t)); -- 2.43.4